This repository was archived by the owner on Nov 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 160
move atomic gossip #706
Merged
Merged
move atomic gossip #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ceyonur
commented
Dec 23, 2024
darioush
reviewed
Dec 23, 2024
qdm12
reviewed
Dec 23, 2024
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
darioush
approved these changes
Dec 26, 2024
qdm12
approved these changes
Dec 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Moves atomic gossip files and handlers to atomic pkg
Removes legacy non-used gossip handler
How this works
This pull request includes several changes to the
peer/network.goandplugin/evmfiles, primarily focused on removing the gossip handler functionality and refactoring the atomic transaction handling. The most important changes include removing the gossip handler, updating thenetworkstruct and its methods, and adding new functionality for atomic transactions.Removal of Gossip Handler:
peer/network.go: Removed theSetGossipHandlermethod and thegossipHandlerfield from thenetworkstruct. Updated related methods to remove references to the gossip handler. [1] [2] [3] [4] [5]Refactoring of Atomic Transactions:
plugin/evm/atomic/gossip.go: Added new file to handle gossip-related functionality for atomic transactions, includingGossipAtomicTxMarshallerandGossipAtomicTxtypes.plugin/evm/atomic/mempool.go: Renamed and refactored the mempool handling for atomic transactions, including updating import paths and changing types fromatomic.TxtoTx. [1] [2] [3] [4]Test Updates:
peer/network_test.go: Updated tests to reflect the removal of the gossip handler and the introduction of atomic transaction handling, including changes to thesync/atomicimport and various test functions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Minor Changes:
plugin/evm/admin.go: Updated theGetVMConfigmethod to useclient.ConfigReplyinstead of a localConfigReplytype.These changes improve the codebase by removing unused functionality and refactoring existing code to better handle atomic transactions and their related operations.
How this was tested
UT/E2E tests should cover this.
Need to be documented?
No
Need to update RELEASES.md?
Yes