Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

Conversation

@ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Dec 13, 2024

Why this should be merged

Moves atomic gossip files and handlers to atomic pkg
Removes legacy non-used gossip handler

How this works

This pull request includes several changes to the peer/network.go and plugin/evm files, primarily focused on removing the gossip handler functionality and refactoring the atomic transaction handling. The most important changes include removing the gossip handler, updating the network struct and its methods, and adding new functionality for atomic transactions.

Removal of Gossip Handler:

  • peer/network.go: Removed the SetGossipHandler method and the gossipHandler field from the network struct. Updated related methods to remove references to the gossip handler. [1] [2] [3] [4] [5]

Refactoring of Atomic Transactions:

  • plugin/evm/atomic/gossip.go: Added new file to handle gossip-related functionality for atomic transactions, including GossipAtomicTxMarshaller and GossipAtomicTx types.
  • plugin/evm/atomic/mempool.go: Renamed and refactored the mempool handling for atomic transactions, including updating import paths and changing types from atomic.Tx to Tx. [1] [2] [3] [4]

Test Updates:

Minor Changes:

  • plugin/evm/admin.go: Updated the GetVMConfig method to use client.ConfigReply instead of a local ConfigReply type.

These changes improve the codebase by removing unused functionality and refactoring existing code to better handle atomic transactions and their related operations.

How this was tested

UT/E2E tests should cover this.

Need to be documented?

No

Need to update RELEASES.md?

Yes

@ceyonur ceyonur mentioned this pull request Dec 15, 2024
@ceyonur ceyonur changed the title move attomic gossip move atomic gossip Dec 23, 2024
@ceyonur ceyonur marked this pull request as ready for review December 23, 2024 16:26
@ceyonur ceyonur requested review from a team and darioush as code owners December 23, 2024 16:26
Base automatically changed from move-atomic-txs to master December 30, 2024 19:12
@ceyonur ceyonur merged commit c167754 into master Dec 31, 2024
8 checks passed
@ceyonur ceyonur deleted the move-atomic-gossip branch December 31, 2024 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants